LonelyCpp / react-native-youtube-iframe

A wrapper of the Youtube-iframe API built for react native.
https://lonelycpp.github.io/react-native-youtube-iframe/
MIT License
603 stars 153 forks source link

Closed captioning not appearing in fullscreen mode #199

Closed tordog closed 2 years ago

tordog commented 2 years ago

Describe the bug Closed captioning shows up when video is displayed inline, but disappears when changed to fullscreen. The bottom bar of the video also does not show the closed captioning icon in fullscreen, but it's there and selectable when played inline.

To Reproduce Steps to reproduce the behavior: Play video inline. Enable closed captioning for the video via bottom bar. Expand to fullscreen

Code: `import YoutubePlayer from 'react-native-youtube-iframe';

<YoutubePlayer height={height} width={width} videoId={videoID} onChangeState={onStateChange} webViewProps={{ scrollEnabled: false, }} />`

Expected behavior When opening a video in fullscreen with closed captioning on, the closed captioning should still display Closed captioning options should also display in the bottom bar in fullscreen mode

Smartphone (please complete the following information):

LonelyCpp commented 2 years ago

It looks like the safari fullscreen subtitle bug has been around for a long time, and hasn't been fixed by apple or google yet.

some discussions I found online :

since the closed captioning is fully handled by youtube's player, this library can't practically do anything about it :(

I'm open to suggestions tho, so if you have any leads please let me know.