LonelyCpp / react-native-youtube-iframe

A wrapper of the Youtube-iframe API built for react native.
https://lonelycpp.github.io/react-native-youtube-iframe/
MIT License
603 stars 153 forks source link

Video is not correctly expanding on Android 11 first time #235

Open VSaulis opened 2 years ago

VSaulis commented 2 years ago

Describe the bug Video is not correctly expanding on Android 11 first time

To Reproduce Click expand button in youtube controls

Expected behavior Video expand and fill all screen

Screenshots image

Smartphone (please complete the following information):

Additional context

<Youtube
        height={(Dimensions.get("screen").width * 0.87 * 9) / 16}
        width={Dimensions.get("screen").width * 0.87}
        videoId={videoId}
      />
DmitriyGalyanov commented 2 years ago

The only way I found is to reload video on Expanding to Full Screen

Here is simplified (yet usable) code

It requires changes in source code, but, unfortunately, I do not have time to create a PR You can use patch-package or create a PR yourself

// in PlayerScripts.ts
type TLoadAndPlayVideoByIdParams = {
  videoId: string;
  startSeconds?: number;
  endSeconds?: number;
};
// add to PLAYER_SCRIPTS
loadAndPlayVideoByIdScript: (params: TLoadAndPlayVideoByIdParams) => {
    return `player.loadVideoById(${JSON.stringify(
      params,
    )}); true;`;
  },

// inside YoutubeIframe component
const injectJs = (jsToInject: string) =>
    webViewRef.current?.injectJavaScript(jsToInject);

const reload = async (startTimeInSeconds?: number) => {
    if (!videoId) {
      return;
    }

    const currentTime = await getCurrentTime();
    const _startTimeInSeconds = startTimeInSeconds ?? currentTime ?? 0;
    injectJs(
      PLAYER_SCRIPTS.loadAndPlayVideoByIdScript({
        videoId,
        startSeconds: _startTimeInSeconds,
      }),
    );
  };

Then you can combine it with onFullScreenChange and that's it!