LongSoft / UEFITool

UEFI firmware image viewer and editor
BSD 2-Clause "Simplified" License
4.44k stars 629 forks source link

Native support for UI Dark Mode #276

Closed vit9696 closed 1 year ago

vit9696 commented 2 years ago

Apparently there is white text on white background in some places:

Screenshot 2022-08-27 at 18 47 20 Screenshot 2022-08-27 at 18 46 11
yeggor commented 2 years ago

I just now noticed that this has already been discussed. Do you think this solves the problem with protected ranges colors: https://github.com/LongSoft/UEFITool/pull/293?

NikolajSchlej commented 2 years ago

Support for macOS dark mode had been recently added to Qt6, but had not been backported to Qt5 in any way, so we should start using Qt6 (but remain compatible with the last Qt build under LGPLv2.1 - 5.6.3, with some minor UI issues if needed) and get that for free.

@yeggor also showed that darkX colors are much nicer-looking in dark mode in #293, but I'd like to detect both Aqua and Dark modes, and switching between them dynamically.

NikolajSchlej commented 1 year ago

Got Windows 10+ dark mode working as expected, no overrides required: 1

NikolajSchlej commented 1 year ago

Now detection of dark mode and setting colors also works in macOS:

Screenshot 2023-02-11 at 21 39 54
NikolajSchlej commented 1 year ago

Done, the current CI/CD pipeline can successfully generate Qt-6.4.2-based builds for both macOS and Windows, and uses a native installed Qt5/6 on Linux. I consider this issue to be resolved, please open another one if UI Dark Mode doesn't work for you in some way.

NikolajSchlej commented 1 year ago

Confirmed macOS way to determine UI dark mode to work in Linux, enabled it there. 1