v1.16.0 breaks bundled javascript

[bglw]

Hello 👋

v1.16.0 introduces a static fs import in parse/.ts:8. This breaks any frontend bundling that isn't stubbing out node libraries. In a default esbuild run I now get:

 > node_modules/@ltd/j-toml/index.mjs:1:32: error: Could not resolve "fs" (use "platform: 'node'" when building for node)
    1 │ import { readFileSync } from 'fs';

Could this be changed to something like a dynamic import behind a try? Loosely something like:

let fs = { readFileSync: () => { throw Error("readFileSync unsupported outside of node"} } };
try {
    fs = await import('fs');
}

Or something behind a platform flag.

[LongTengDao]

I see.

Or something behind a platform flag.

How?

[bglw]

Hmm, I was under the impression there was a supported way to check but it doesn't look like there is.

The checks in the browser-or-node package look simple enough to re-implement, though.

[bglw]

In saying that, I don't know if other packages provide any workaround for this, so maybe it's idiomatic for users to fix this in their bundler configuration... 🤔

[LongTengDao]

I don't know any way good enough. I removed the statically module loading, hope that would help?

[bglw]

Ah, that's perfect. Thanks a tonne! 😄 🎉