search

Longan-Labs / Arduino_CAN_BUS_MCP2515

Arduino CAN Bus library, MCP2515/MCP2551
https://www.longan-labs.cc/
MIT License
128 stars 372 forks source link

ext not initialized in sendMsgBuf #14

Closed yoh-there closed 7 years ago

yoh-there commented 7 years ago

Leaving this here as there is no Issues tab on Cory Fowlers fork, but it is relating to that v1.5 fork.

Line 1070 initializes rtr, but not ext, often leaving ext unequal 0 unintended. Loopback example returned extended frames. Suggest to change that line to

INT8U ext = 0, rtr = 0;

Thank you for the great work.

yoh-there commented 7 years ago

Closing here as @ichrysou converted this issue to a commit/pull request in Cory's fork.