LongmaoTeamTf / deep_recommenders

Deep Recommenders
Apache License 2.0
325 stars 108 forks source link

Fix bug from `transformer.ipynb` in `/experiments` #12

Closed A-baoYang closed 2 years ago

A-baoYang commented 2 years ago

Hi, thank you so much for open sourcing your project, it helps me a lot!! Here I just have one simple bug to report:


Source: 3rd code cell from notebook

After ran the notebook and traced your code (deep_recommenders/keras/models/nlp/Transformer.py), the input of Transformer class object needs 2 parameters (encoder_inputs, decoder_inputs), it should not be a list.

SharpCX commented 2 years ago

We have fix the issues, thx.