search

Longwelwind / swords-and-ravens

An online platform to play the board game "A Game of Thrones: The Board Game 2nd Edition"
https://swordsandravens.net/
GNU General Public License v3.0
109 stars 30 forks source link

Increase game components' maxHeight to utilize all of the available v… #1834

Closed G2HJei closed 4 months ago

G2HJei commented 5 months ago

1833

Increase game components' maxHeight to utilize all of the available vertical space:

image

This is useful since the map is usually scrollable on most screens and this will reduce this a little.

gereon77 commented 5 months ago

@G2HJei Thanks for your contribution! To be honest... I don't remember why I have chosen 95% viewheight but I am sure it had a reason. I will retest it locally and check how it looks with 100%. If it doesn't cause any side effects in any scenario, I'll merge this PR.

gereon77 commented 4 months ago

@G2HJei 100vh is causing outer scrollbars on 1080x1920:

image

Therefore I keep 95vh and drop this branch.

G2HJei commented 4 months ago

It is probably due to an element on the 8player map having extra margins. I will see if I can find it and create a new PR. 🙂