search

LonnyGomes / hexcurse

Hexcurse is a ncurses-based console hexeditor written in C
Other
180 stars 17 forks source link

Added colors #16

Closed Kerrigan29a closed 9 years ago

ghost commented 9 years ago

Very cool! Thanks @Kerrigan29a, I'm excited to incorporate this! Would it be possible to perhaps squash the commit for the Added Travis support and to maybe break out build script updates and code changes you added as two separate commits? It just may be easier to see all the work you did! Thanks for the contribution, I'll try testing this later today!

Kerrigan29a commented 9 years ago

I made the pull request before adding the Travis Support, I don't know why it was also added. If you erase the .travis.yml file and restore the 2 readme files the Travis support will be disabled.

Kerrigan29a commented 9 years ago

I've never manager a pull request in my repos, so I don't know about it. Can you select by hand which commits use in the merge of this pull request?

stevenhoneyman commented 9 years ago

I look forward to testing this out, thanks!

No, you can't pick-and-choose which commits to use. Any commits you add to your master branch will get added to this pull request. What is supposed to happen is you create a new branch e.g. "colorsupport" with only changes affecting this feature addition, and submit the request for that branch. Anything else you change in another branch or master will not be added in that case.

Kerrigan29a commented 9 years ago

ok, I'll do that

Kerrigan29a commented 9 years ago

Added new request #17

ghost commented 9 years ago

The merge was implemented with PR #17 so I'm closing this one out.