LonoCloud / lein-voom

Tool for generating artifacts versioned on the most recent git commit sha and commit time.
Eclipse Public License 2.0
97 stars 14 forks source link

`build-deps` fails to build artifact at GMT midnight and noon (12am/12pm) #34

Closed abrooks closed 10 years ago

abrooks commented 10 years ago

When the commit time is midnight or noon (12am/12pm) GMT, the build fails printing the expected and found times, explaining: "Could not resolve expected vs found timestamps."

This is because the modular 24hr time fix for #30 converts the hours 00 and 12 (in 24hr time to 0. In 12hr time, these hours are both called 12. i.e. While the first hours of the new day in 24hr time are 00, 01, 02, ..., they're 12am, 1am, 2am, ... in 12hr time. The same is true for the PM hours -- 12pm is the first hour of the second half of the day.