search

Loobinex / keeperfx-unofficial

KeeperFX - Unofficial release
60 stars 7 forks source link

Rewrite setup_move_out_of_cave_in #175

Closed Loobinex closed 4 years ago

Loobinex commented 4 years ago

Also made some changes to flee position getting so as to have the original behaviour rather than weird behaviour.

Loobinex commented 4 years ago

@AdamPlenty In this commit I don't see any changes to 'get_flee_position', which I believe an earlier version did. I don't see the current version causing any additional errors. So I believe after the TESTLOG messages are removed, I believe you can click 'Ready for review' and I'll do one quick last test and I'd merge.

Unless you belief there's still things to do to get this to the original behavior,...

Further improvements to cave-in are indeed desired, but I would do those in a separate commit.

AdamPlenty commented 4 years ago

@AdamPlenty In this commit I don't see any changes to 'get_flee_position', which I believe an earlier version did. I don't see the current version causing any additional errors. So I believe after the TESTLOG messages are removed, I believe you can click 'Ready for review' and I'll do one quick last test and I'd merge.

Unless you belief there's still things to do to get this to the original behavior,...

Further improvements to cave-in are indeed desired, but I would do those in a separate commit.

I believe the original code only checked for the existence of a dungeon, not that the fleeing creature can actually get there? Weirdness happens if it tries to get to co-ordinates it cannot. This should try the next possible flee location instead.