search

Loobinex / keeperfx-unofficial

KeeperFX - Unofficial release
60 stars 7 forks source link

Memory #88

Closed AdamPlenty closed 4 years ago

Loobinex commented 4 years ago

What does this do? And how to test it?

AdamPlenty commented 4 years ago

What does this do? And how to test it?

I'm not sure what it does, but you can test it by looking at the log file (in the statement 'PhysicalMemory'). Theoretically this should double the amount of memory available to KeeperFX.

Loobinex commented 4 years ago

I always lean towards 'if it ain't broken, don't fix it', especially if we don't know exactly what we're doing. I don't even know why it was commented out in the first place, but I see it was never enabled. It went from non-existent to commented out straight away.

I'll check it out, but I find it very dangerous, because will we ever find out if it starts to crash only after we use too much memory, especially if you usually don't use as much?

Loobinex commented 4 years ago

I looked into it, and I think we should not make this change. Tell me what you think.

I believe that all that these lines of code do, is set the variable 'mem_size'. And that variable does not determine how much memory the game can use, but based on this variable the memory intensive features are disabled. The current highest value (32 Mb), already has all features enabled, so giving it an even bigger value does absolutely nothing.

With bigger values enabled, we could in the future when we add even more memory intensive features, like really high def graphics or something, disable those features when you don't have enough memory for them, but enough to use all the current features. But it makes more sense to set this up only when the need arrives.