Refactoring Shader Code Implementation

[AdrienBousquieEPFL]

[!WARNING] OUTDATED Description see comments below

Description

• Refactor the Skybox and Star components to utilize the newly created classes:
  • IndexBuffer
  • VertexBuffer
  • ColorBuffer
    (introduced in #159).
• Merge the functionality of:
  • ShaderProgram from #159
  • ShaderUtils from #188.

Objective:

This is a code refactoring task aimed at improving code readability and maintainability for better team understanding and consistency.

Expected Outcome:

• Both Skybox and Star components uniformly use the new buffer classes.
• A cleaner, more cohesive codebase that eliminates redundancy in shader-related utilities.

[AdrienBousquieEPFL]

Issue Update Required: Revisit Implementation Details

The current issue description and context are outdated, as significant changes have been made to the codebase since this issue was initially defined. The original assumptions and proposed solutions may no longer align with the current state of the project.

Next Steps

• Reevaluate the problem statement in light of the recent code changes.
• Discuss and redefine the objectives and implementation approach.
• Update this issue with a revised description and actionable tasks.

This issue needs to be re-discussed to ensure alignment with the updated codebase and project requirements.

Task

• [ ] Redefine the issue

[AdrienBousquieEPFL]

Issue Redefinition: Refactoring Shader Code Implementation

Context:

The current shader code implementation requires improvement. The shader code is currently embedded directly within the application codebase, leading to maintenance challenges and unnecessary duplication.

Proposed Solution:

1. Externalize Shader Code: Move the shader code currently embedded in the application code into separate .glsl files.
2. Eliminate Duplications: Identify and remove any duplicate methods in the ShaderProgram.kt and ShaderUtils.kt files.

Goals:

• Simplify the shader management process by leveraging .glsl files.
• Maintain compatibility with the current codebase, ensuring no drastic architectural changes at this stage.
• Improve maintainability and reduce redundancy.

Task List

• [x] Create .glsl Files

• [x] Move Shader Code

  • Transfer the embedded shader code into the newly created .glsl files.
  • Ensure each .glsl file is properly named and formatted.

• [x] Update Code to Load .glsl Files

  • Modify ShaderProgram.kt and ShaderUtils.kt to load shader code dynamically from the .glsl files.
  • Test the loading mechanism to ensure shaders are applied correctly.

• [x] Eliminate Duplicate Methods

  • Identify and document duplicate methods in ShaderProgram.kt and ShaderUtils.kt.
  • Refactor the code to consolidate these methods into a single, reusable implementation.

• [x] Test Shader Functionality

  • Verify that the refactored shaders work as expected across all scenarios.
  • Check for any performance regressions or errors during rendering.