search

Looking-Glass / looking-glass-webxr

WebXR for Looking Glass displays
https://docs.lookingglassfactory.com/developer-tools/webxr
Apache License 2.0
66 stars 16 forks source link

Feature Request: (Re-)Expose user setting for the number of views #40

Open tbirdso opened 1 year ago

tbirdso commented 1 year ago

Description

In the 0.3.0 release it was possible to set the number of views to render on the Looking Glass display via a UI slider. That feature was useful for managing the tradeoff between performance and fidelity for large, complex, or otherwise demanding datasets.

In 0.4.0 it appears that user setting is no longer exposed through the public API (https://github.com/Looking-Glass/looking-glass-webxr/blob/main/src/LookingGlassConfig.ts#L162) and is instead set under the hood to a constant number of views to make up the quilt. Due to import/namespace changes from 0.3.0 to 0.4.0 it appears to be difficult to swap versions in and out in a consuming project.

Feature Request

As a minimum goal, it would be nice for numViews to be exposed through the public API again for programmatic adjustment during ongoing rendering.

As a stretch goal, it would be useful for a UI slider to be added back to adjust this value.

BryanChrisBrown commented 1 year ago

re-added this value in this PR https://github.com/Looking-Glass/looking-glass-webxr/pull/45

UI slider is definitely possible to add again as well, I recently pushed up another PR with improved UI for the settings panel, I'll see if I can make that more configurable to allow for custom UI elements to be chosen via the config.