search

Looking4Group / L4G_Core

Looking4Group Core
http://looking4group.eu
GNU General Public License v2.0
37 stars 69 forks source link

Seal of Blood #1303

Closed Xadras closed 8 years ago

Xadras commented 8 years ago

Originally reported by: Anonymous

Seal of Blood deals more backlash damage then the 10% it is supposed to do. Could be a similar issue as it was on retail.

Xadras commented 8 years ago

Original comment by Tolgren (Bitbucket: Tolgren, GitHub: Tolgren):

SoB has 0% spell damage coeffiicient, shouldn't gain +Holy Damage from JotC. I made a detailed research on corecraft bugtracker some time ago: https://github.com/ccshiro/cc-buglist/issues/912

Xadras commented 8 years ago

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):

https://github.com/TBCPvP/TBCPvP/commit/f62ad9a9d337c3da9db14097457dd3a9009a8937

https://github.com/TBCPvP/TBCPvP/commit/d68a47b5fb7b4658a6f603614184a8d92713b5b6

Xadras commented 8 years ago

Original comment by Belgarion Garedson (Bitbucket: Ravaki, GitHub: Unknown):

Apparently, according to the sources I read, the bonus from Judgement of the Crusader is typed as holy spell damage. Whereas Seal of Command's proc has a small spelldamage component, Seal of Blood's proc has no such component. The Judgement of Blood does have such a component and it does receive the increased spell damage of the Judgement of the Crusader. All of the above seals and judgements should get the percentage increase from the Sanctity aura.

Xadras commented 8 years ago

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):

just gathering information, the part you guys should help with...

Xadras commented 8 years ago

Original comment by Smittens (Bitbucket: Smittens, GitHub: Smittens):

The wowwiki does not say that it should not receive a bonus from Judgement of the crusader, in all reality it is supposed to increase holy damage, which is what seal of blood does even tho it is based on physical damage when it relates to crit and procs, which is why it can still be resisted. This is also the same concept as crusade strike, its based on physical but still does holy damage and is increased by judge of crusader.

Xadras commented 8 years ago

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):

Issue #1565 was marked as a duplicate of this issue.

Xadras commented 8 years ago

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):

http://wowwiki.wikia.com/wiki/Seal_of_Blood?oldid=1621246

#!c++

As it turns out Seal of blood has never received a bonus from JotC. It should however gain dmg from the Sanctity aura.

Source http://web.archive.org/web/20080221133542/http://forums.worldofwarcraft.com/thread.html?topicId=104544938&sid=1&pageNo=6

Xadras commented 8 years ago

Original comment by julen mediavilla (Bitbucket: Apocsteel, GitHub: Unknown):

Seal of Blood is not getting any bonus damage from Seal of Crusader or Sancticy aura, pretty much bugged.

Xadras commented 8 years ago

Original comment by Xadras (Bitbucket: Xadras, GitHub: Xadras):

Removing component: Spell (automated comment)

Xadras commented 8 years ago

Original comment by ASd DSA (Bitbucket: asd1234321dsa, GitHub: Unknown):

"The Paladin Retribution talents Sanctified Seals, Vengeance, and Crusade all affect the damage dealt by this seal (prior to patch 2.1.2 there was a bug that would cause it to doubly affect the returned damage component of this seal, making the returned damage more than the 10% stated on this seal's tooltip)." Taken from WoWWiki, most likely the cause. Don't know if it helps.

AnonXS commented 8 years ago

1270