search

Looking4Group / L4G_Core

Looking4Group Core
http://looking4group.eu
GNU General Public License v2.0
37 stars 69 forks source link

Vile Poisons talent not working [Rogue] #2014

Open Xadras opened 8 years ago

Xadras commented 8 years ago

Originally reported by: Anonymous

The talent Vile Poisons does not seem to work. After trying to cleanse poisons in duels many times over, not a single poison cleanse was resisted. This talent is enormously important for rogues in PvP.

Xadras commented 8 years ago 

SELECT * FROM `spell_affect` WHERE `entry` IN (16513,16514,16515,16719,16720) AND `effectID` = 2;

UPDATE `spell_affect` SET `SpellFamilyMask` = WHERE `entry` IN (16513,16514,16515,16719,16720) AND `effectID` = 2; -- 268558336

https://github.com/ccshiro/cc-buglist/issues/1086

Wound Poison needs to have SpellFamilyMask edited as it currently doesnt have one and therefore cant be affected by vile poison: 43461,13224,13223,13222,13218

See: http://db.hellfire-tbc.com/?spell=11398 has SpellFamilyFlags = 0x0000000000008000 works

See: http://db.hellfire-tbc.com/?spell=43461 has SpellFamilyFlags = 0x0000000000000000 doesnt

Xadras commented 8 years ago

Original comment by James Phoenix (Bitbucket: JamesAPhoenix, GitHub: JamesAPhoenix):

Wound poison and crippling poison are dispelling way too fast vs WD.

I can honestly say that is currently not working as intended and I would greatly appreciated if it could be looked at. Also the poison shiv resist chance is very high.

Even with 3 / 4 wound, my crippling was being taken off too regularly.

Please for the love of this server investigate the poison mechanics when you have some spare time. (It could be abolish poison not working correctly with vile poisons?)

Best regards & many thanks.

Xadras commented 8 years ago

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):

https://bitbucket.org/lukaasm/hellground-wowemu/commits/f1be73d1f0e0483952378d95db0b9911a803e23a is identic.

Xadras commented 8 years ago

Original comment by schaka NA (Bitbucket: schaka, GitHub: schaka):

https://bitbucket.org/lukaasm/hellground-wowemu/commits/

https://bitbucket.org/lukaasm/hellground-wowemu/commits/f1be73d1f0e0483952378d95db0b9911a803e23a

Idk if these are applied to the DB currently. If not, use robinsch's https://github.com/robinsch/SpellMaskCreator and create the correct mask that includes ALL poisons.

I've already created a pull request correcting this for healer classes. I guess I forgot rogues.

Edit: Since I don't play here, I suggest someone with 5 minutes of time should just count how many times dispel is actually resisted (only wound, do NOT apply crip). If it's closer to 20% than 40%, that might be a completely different issue which would be code-related.

Xadras commented 8 years ago

https://github.com/Looking4Group/L4G_Core/issues/2489

Xadras commented 8 years ago

Original comment by James Phoenix (Bitbucket: JamesAPhoenix, GitHub: JamesAPhoenix):

@Anonx

Please can this be looked into? It does seem like abolish poison is currently dispelling poisons too much.

Best regards,

James.

Xadras commented 8 years ago

Original comment by Delta (Bitbucket: Deltayeah, GitHub: Unknown):

Don't wana mention Shiv resist 2 or 3 times in row...

Needs to be looked into for real. :)

Xadras commented 8 years ago

Original comment by Delta (Bitbucket: Deltayeah, GitHub: Unknown):

Ok i tested outside of Shat with my friend, after i had biggest shit time while i stack wounds on targets in arena. Druid's Abolish Poison rapes Vile Poisons "40% chance to resist dispel efect " in every tick almost.

Trench, please , make some alt rogue , and make druid alt, and try it out.

Regards,

Xadras commented 8 years ago

Original comment by Trenchfox (Bitbucket: Trenchfox, GitHub: Trenchfox):

The + damage portion of the talent works. I would need to look into the resist issues.