Closed Xadras closed 7 years ago
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
Thesis: Frostbite should not be triggered while other Root Spells are active:
Now i will start to look for a point / other example on how to implement frostbite not triggering when another mage root spell is present, maybe even all root spells, need more videos to be more sure that this is actually a blizzlike fix.
This will be worked / researched on in a new topic.
Well, ok
http://www.youpak.com/watch?v=K4WR0JW5jWM 2:42 : frost nova, 2:49 : proc frostbite, 0 dr.
https://www.youtube.com/watch?v=a3yTchRq8Ls 0:47 : proc frostbite, 0:55 : frost nova, 0 dr.
https://www.youtube.com/watch?v=COlMAg2zrrk 14:55 frost nova, 15:02 : proc frostbite, 0 dr.
And here's a doom squad guy if u don't like asian pro players :D http://www.dailymotion.com/video/x9yjzz_agramon-2-part1_videogames 1:37 : proc frostbite, 1:38 frost nova (we can't clearly see about the dr here), 1:47 frost nova (from elem), only 1 dr applied.
And i wanted to add something else : Frostbite shouldn't be able to proc if the target is already under a freeze effect (frost nova/freeze), because nova effects last longer. Even if there are only 2s remaining from the nova, frostbite still shouldn't be able to proc.
http://wowwiki.wikia.com/wiki/Frostbite_(mage_talent)
http://urbad.net/blue/us/96073604-Mage_Q_About_Frostbite_Change_in_Patch
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
@Freeznfire Ye i chose the wrong class and i'm still having fun because of people i'm playing with, but ye, losing 150 rating in 5 arenas vs bad people just because mage is unplayable atm give me cancer sometimes x)
@Anonx I know u tried ur best, i don't blame u for trying to fix things, but maybe u waited to long before reversing changes. Meh, i hope it won't take too long to do this now :>
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
we are going to revert diminishing returns changes to the state befor i started working on this matter, where frostbite works and then we are going to fix specific drs without a total rework which might break things. I am sorry i do not know how this happend to only frostbite being bugged and i am aware that i destroyed pvp exp for competetive frostmages.
I was too confidend that i knew what i was doing and ended up breaking parts of the most important pvp mechanic.
Original comment by Freeznfire (Bitbucket: Freeznfire, GitHub: Unknown):
Wow youre still playing mage on this server? You have to have cancer by now.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Still have to play every game without ice armor to avoid any frostbite proc feelsmagefuckedman.
U have no clue about both bugs?
Did u try something with database?
I know u spent time on it but it's really game breaking for frost mages tho , espacially the dr issue :(.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
About the frostbite proc on nova/freeze effect, it may be in function IsSpecialNoStackCase in SpellMgr cpp file, where frostbite should'nt be able to stack with nova/freeze.
Original comment by Freeznfire (Bitbucket: Freeznfire, GitHub: Unknown):
Warrior with dispels = immune to all my stuff in 2 casts, this needs to be fixed. How do I kite a warrior if hes immune to my slows, which shouldnt be possible.
Its really simple, as a quick temporary fix take frostbolt off DR's with anything... The freeze frostbite frostnova DR shit can be fixed later, like tomorrow.
Original comment by Silverstar (Bitbucket: Silverstarz, GitHub: Silverstarz):
Frostbite is a "triggered root " not a "controlled", everyone can see on some video from retail frostbite is not on a DR with nova or pet nova. Here if you duel a rogue or war he proc 2frostbite and then he got immune to your nova or pet nova its just totaly broken...
i've never seen a mage getting immune to nova on a 1v1 fight. and here its the case pls fix.
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
Frostbite seems to be on the controlled root dr. But idk y.
https://bitbucket.org/oregon/oregoncore/commits/ebcb6885d2438be12699a95e8b83a6b3ac7d9c9f
Original comment by Freeznfire (Bitbucket: Freeznfire, GitHub: Unknown):
As you can see from what "randomscripts linked: http://wowwiki.wikia.com/wiki/Diminishing_returns
Frostbite does not share DR with frost nova or freeze. It says in patch 2.1.0 DR was added to frostbite, but its ONLY on dr with frostbite, not freeze or nova
Original comment by Freeznfire (Bitbucket: Freeznfire, GitHub: Unknown):
No mage should solo be able to cause an immune with nova, it shouldnt share DR with frostbite, it should only share with freeze. At the most you can nova then freeze and it would be halfed, In addition frost nova is breaking way too easy, I can rarely get a frostbolt off on a mob after frost nova. My nova's break 95% of the time when another player hits it with first damage. Its almost impossible to shatter someone unless im solo or im doing it with my pet. That isn't blizzlike.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Ye just look at my posts i linked some videos, we can clearly see nova is diminishing.
Anon X, I think frostbite's problem is the exact same as mace stun drs and all these types of dr : controlled roots and random roots don't share the same dr, controlled stun and random stun don't share the same dr, etc.
We got the same problem here, mace spec stun and thunder stun are random stuns, so they have to share the same dr, but they don't share anything with controlled stuns (charge for exemple): https://bitbucket.org/looking4group_b2tbc/looking4group/issues/2165/mace-stun-dr
http://wowwiki.wikia.com/wiki/Diminishing_returns Under "Shared Diminishing Returns Categories" Even if some drs are not the same in 2.x.x (silence for exemple), I think the mechanic was the same.
To conclude on this point, the fix u might apply here is all about controlled/random drs, and not simply frostbite or w/e.
I'm still searching for an idea to fix the frostbite proc on nova tho.
Original comment by A Buescher (Bitbucket: BuschaZ, GitHub: Unknown):
I am also pretty confident Nova was diminishing... Might still be mistaken tho
Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):
im 100% sure frost nova can cause immune to CC, roots are affected by DRs
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
http://wowwiki.wikia.com/wiki/Diminishing_returns?oldid=1613290 -> Frost Nova Yes No Root -> Diminishing Controlled Root.
And no did no changes to Frostbite procc as i dont know where to set of from.
https://github.com/Looking4Group/L4G_Core/blob/master/src/game/SpellMgr.cpp#L4362
Original comment by Freeznfire (Bitbucket: Freeznfire, GitHub: Unknown):
I saw immunes on frost nova the other day, I thought it was a bug but that is proof. 2nd of all Im pretty sure frost nova should never cause immune.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
I don't know if u applied something since your last post, but if u did, none of these 2 bugs are fixed atm tho (dr from novas/frostbite & frostbite can still proc when nova is up).
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Thanks a lot, i'll give you feedbacks when changes are applied.
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
https://github.com/cmangos/mangos-tbc/blob/master/src/game/SharedDefines.h
https://github.com/cmangos/mangos-tbc/blob/master/src/game/SpellMgr.cpp
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
It's a pretty hard thing to prove, i only found the link u already read, and never seen people saying "be carefull about frostbite, it can proc and waste his proper dr when a frost nova/freeze is already applied" or things like that.
I've watched soooo many videos from retail (like 15+), never seen a single frostbite proc when nova/freeze were applied.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Well, ok
http://www.youpak.com/watch?v=K4WR0JW5jWM 2:42 : frost nova, 2:49 : proc frostbite, 0 dr.
https://www.youtube.com/watch?v=a3yTchRq8Ls 0:47 : proc frostbite, 0:55 : frost nova, 0 dr.
https://www.youtube.com/watch?v=COlMAg2zrrk 14:55 frost nova, 15:02 : proc frostbite, 0 dr.
And here's a doom squad guy if u don't like asian pro players :D http://www.dailymotion.com/video/x9yjzz_agramon-2-part1_videogames 1:37 : proc frostbite, 1:38 frost nova (we can't clearly see about the dr here), 1:47 frost nova (from elem), only 1 dr applied.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Look at my post just before Silverstar for the dr problem.
I linked the video from 2:48, u can continue until 3:03, we can clearly see Noone using nova and procing frostbite without any dr sharing.
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
The Frostbite effect does not overwrite the Frost Nova effect or the Water Elemental's Freeze effect. These spells have a longer duration (8 seconds vs. 5 seconds) than Frostbite, and thus supersede it. Even if the Frost Nova or Freeze has fewer than 5 seconds remaining, Frostbite will not take effect. However, if the attack with a chill happens to break the freezing effect, it is possible for the Frosbite freeze to take effect immediately.
Seems to have nothing to do with DR as Overwrite means replacing the existant Debuff.
http://wowwiki.wikia.com/wiki/Frostbite_(mage_talent)?oldid=1631922
Its only mentioned that if frost nova debuff breaks due to chill the frostbite debuff can still be active, duration wise.
http://www.youpak.com/watch?v=aZlkojMaJ3w hmh more videos.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
And i wanted to add something else : Frostbite shouldn't be able to proc if the target is already under a freeze effect (frost nova/freeze), because nova effects last longer. Even if there are only 2s remaining from the nova, frostbite still shouldn't be able to proc.
http://wowwiki.wikia.com/wiki/Frostbite_(mage_talent)
Atm if we nova something, and this thing hits and makes frostbite proc, then nova AND frostbite are applied (And with the dr, targets are immune much more quiclky btw).
Original comment by Silverstar (Bitbucket: Silverstarz, GitHub: Silverstarz):
Randomscripts is right its pretty good atm, but people still getting immune to nova and pet nova if we got some frostbite proc and its still annoying to see someone getting immune for these spell ( frost nova and pet nova )
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Well, it's pretty good atm, except for frostbite, which should only share a DR with himself (sharing dr with nova atm (from player & elem))
http://urbad.net/blue/us/96073604-Mage_Q_About_Frostbite_Change_in_Patch
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
A crash occured, still can't play mage, same bugs.
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Ok, thx, i'll give some feedbacks
Original comment by randomscripts (Bitbucket: randomscripts, GitHub: randomscripts):
Well it's not fixed atm - or do u mean we've to wait for an apply or smthg?
Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):
Should be fixed with https://github.com/Looking4Group/L4G_Core/pull/46
Original comment by Melody (Bitbucket: Momohx, GitHub: Unknown):
This is critical in the very sense of the word for mages.
Originally reported by: randomscripts (Bitbucket: randomscripts, GitHub: randomscripts)
Roots, stuns and slows share the same dr as mage.
Let's say a war charges my opponent. My novas (from elem or my char, it's the same) will get a dr (root for 4 sec instead of 8), and my slows too.
If i slow my opponent after a root, a slow or a stun (pounce, charge, nova, coc, w/e), the duration will get affected by a dr too. So my cone of cold will last 5s instead of 11, my frostbolt 6sec, etc.
And ofc, after 3 slows/roots/stuns, my opponents are immune to slows/roots (except for blizzard spec's slow, because it's a physical debuff i guess, and it doesn't trigger a dr from frostbite too).
I set is as a critical bug as a frost mage because this spec is just unplayable atm. Any melee class is immune to slows/roots after 4sec of fight, so we can't do any damage(no fb/icelance on freezed target)/control.