Looking4Group / L4G_Core

Looking4Group Core
http://looking4group.eu
GNU General Public License v2.0
37 stars 69 forks source link

Consecration doesn't proc Judgement of Wisdom #2616

Open Xadras opened 8 years ago

Xadras commented 8 years ago

Originally reported by: Tolgren (Bitbucket: Tolgren, GitHub: Tolgren)


I did a 10 minutes test, not once did JoW proc of the initial debuff application.

Found this combat log from Corecraft bugtracker (which is from around patch 2.4.0):

https://cloud.githubusercontent.com/assets/6951059/4917782/7129df4c-64e9-11e4-8027-a36e41945c10.PNG

Consecration initial application is a spell debuff, which isn't shown in the debuff bar on enemies since a vanilla patch, but it's still there. In the combat log, at time 21:43:31.01 Consecration is applied. 25ms later (server delay?) JoW procs. Any spell debuff -application- can proc JoW, but further damage like in DoTs should NOT proc JoW.


From EJ: http://web.archive.org/web/20090209193622/http://elitistjerks.com/f76/t17193-retribution_dps_theorycraft/

Rotation 1: Autoattack, Crusader Strike, Judgement of Command, repeat Attack Speed: 3.8 seconds

Ideal Mp5 from JoW: 124.23 Mp5

Rotation 2: Autoattack, Crusader Strike, Judgement of Command, Consecration, repeat Attack Speed: 3.8 seconds

Ideal Mp5 from JoW: 147.32 Mp5

Rotation 3: Autoattack, Crusader Strike, Judgement of Blood, repeat Attack Speed: 3.5 Seconds

Ideal Mp5 from JoW: 106.81 Mp5

Rotation 4: Autoattack, Crusader Strike, Judgement of Blood, Consecration, repeat Attack Speed: 3.5 Seconds

Ideal Mp5 from JoW: 128.39 Mp5

As you can see, adding Consecration to the rotation should increase the mana regeneration.


AbaddonL4G commented 7 years ago

so looks like PROC_FLAG_TAKEN_AOE_SPELL_HIT = 0x00002000, // 13 Taken AoE damage spell hit (not 100% shure unused)

is bugged

AbaddonL4G commented 7 years ago

https://github.com/ccshiro/cc-buglist/issues/15