search

Looking4Group / L4G_Core

Looking4Group Core
http://looking4group.eu
GNU General Public License v2.0
37 stars 69 forks source link

when Lighting overload proccs after using Elemental mastery #3388

Open Gwenthyl opened 7 years ago

Gwenthyl commented 7 years ago

the elemental mastery cd gets used and the spell will not crit or be free.

AnonXS commented 7 years ago

if Lighning Overload procced Lightning Bolt is the same as normal Lightning Bolt but just reduced we have a problem here.

We need to exclude Spells without Spellcost from consuming Spellmods.

https://github.com/NostalriusTBC/Core/pull/27/files - spellmods dont get consumed when casting spells with zero cost

http://db.hellfire-tbc.com/?search=Lightning+Overload

Lightning Overload Rank 5
Gives your Lightning Bolt and Chain Lightning spells a 20% chance to cast a second, similar spell on the same target at no additional cost that causes half damage and no threat.
Pbeitelmann commented 7 years ago

This has been fixed as part of this issue:

https://github.com/Looking4Group/L4G_Core/issues/2701

Elemental Mastery will no longer be consumed by Spells that were midair when the buff is gained.

AnonXS commented 7 years ago

Seems to not be fully resolved.