Looky1173 / launchpad-bugs-migration2

0 stars 0 forks source link

[BUG n°1107754] incorrect signal in route CMK #1157

Closed Looky1173 closed 11 years ago

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/bugs/1107754

Property Value
Reported by danio (dammul)
Date reported Mon, 28 Jan 2013 10:55:19 GMT

In polish route CMK Link : http://cmk.cba.pl/2.html

All signal are "red"

In "activities" and "explorer routes"

This route have "new signal code" by Tomska and Psob to msts. I think that it is problem.

Link : http://www.ts-studio.eu07.pl/ Raiding the train is ok, onlu signall error.

Sorry, my english is bad.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/1

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Mon, 28 Jan 2013 13:02:37 GMT

Could you please attach log-file? Are the new signals standard part of the route or must they be downloaded separately?

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/2

Property Value
Posted by danio (dammul)
Date posted Mon, 28 Jan 2013 14:07:37 GMT

New signals are included with CMK route. Please download route from link below:

http://cmk.cba.pl/2.html

http://www.danio.trainsim.pl/cmk/OpenRailsLog.txt

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/3

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Mon, 28 Jan 2013 16:36:12 GMT

Problem is crash in processing of sigscr.dat file which defines the signal logic. Will investigate.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/4

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Tue, 29 Jan 2013 22:35:24 GMT

The problem is caused because a IF statement is followed by multiple lines which are not enclosed by 'curly brackets' ( { and } ). The OR script parsing requires that multiple statements following an IF statement are enclosed.

The problem occurs in line 739 of file sigscr_TS0001.dat, in script for signal PKP_SEM_4K_BC1.

Attached is an updated version of the script which works correctly.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/5

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 16:49:27 GMT

This problem repeats.

Log : http://www.danio.trainsim.pl/cmk/OpenRailsLog.txt

New file

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/6

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 17:05:56 GMT

http://www.fotosik.pl/pokaz_obrazek/732ac58a486e8dfe.html Screen

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/7

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Wed, 30 Jan 2013 17:37:49 GMT

Actually, this is a different error. Something goes wrong as you pass the signal at danger. The sigscr.dat file is now processed correctly.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/8

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 17:57:34 GMT

can you repair this problem ?

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/9

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Wed, 30 Jan 2013 18:19:04 GMT

Well, I will try, but my first attempt to replicate it didn't work - the program did not crash. I'll see what I can do.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/10

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 18:28:21 GMT

OK, thanks. I can do screen etc.

This file : sigscr_TS0001.dat

I must paste in "routes/cmk" yes ? I must change old file ?

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/11

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Wed, 30 Jan 2013 20:56:01 GMT

You can paste the new file in routes/cmk, it replaces the old file. Make a copy of the old file first if you want to make double sure.

As for the error : I know where it happens and I think I know what I can do about it, but I also want to know why it happens. I thought I knew that, ran a train in such a way thay I though that would create this error - and nothing happened. It is difficult to test if a change in the program resolves the problem if you can not create that problem.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/12

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 22:07:24 GMT

When i came through signal my train stopped and showing me an error on a screen above. I have been tried many ways, but it still does'nt work. Just typical Smile Kind Regards

And i forgot. This error on the screen showing himself when i switch the junction. Hopefully that will be a helpful tip. I believe deply you will work it out. Cheers.

Translate by my friends - lalek

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/13

Property Value
Posted by danio (dammul)
Date posted Wed, 30 Jan 2013 22:10:30 GMT

I did as you said, but problem didn't disappear. It is still existing.

When i came through signal my train stopped and showing me an error on a screen above. I have been tried many ways, but it still does'nt work. Just typical Smile Kind Regards

And i forgot. This error on the screen showing himself when i switch the junction. Hopefully that will be a helpful tip. I believe deply you will work it out. Cheers.

Translate by my friend - lalek

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/14

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Wed, 30 Jan 2013 22:50:43 GMT

Sorry - should have been more clear : the file I send you solves the problem you first reported, not this second problem.

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/15

Property Value
Posted by danio (dammul)
Date posted Thu, 31 Jan 2013 09:29:59 GMT

ok, we wait :) Thanks

Looky1173 commented 11 years ago

Imported from https://bugs.launchpad.net/or/+bug/1107754/comments/16

Property Value
Posted by r.roeterdink (r-roeterdink)
Date posted Tue, 05 Feb 2013 18:18:11 GMT

Committed in version 1424