fix: [modules] Gracefully accept no hashlookup fixes #916

Lookyloo / lookyloo

Lookyloo is a web interface that allows users to capture a website page and then display a tree of domains that call each other.

https://www.lookyloo.eu

Other

664 stars 83 forks source link

fix: [modules] Gracefully accept no hashlookup fixes #916 #917

Closed cvandeplas closed 1 month ago

cvandeplas commented 1 month ago

Type of change

Description: Fixes bug #916 - accept hashlookup being disabled

Select the type of change(s) made in this pull request:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change or fix to documentation)

Fixes #916

Proposed changes

cleanly show the message to the user instead of throwing an error in the code.

cvandeplas commented 1 month ago

Note: the PR also contains minor changes in the redis script. Note2: commenting out the following lines in indexing.conf and cache.conf is needed for redis 7.0.x to start properly.

# locale-collate ""
# set-max-listpack-entries 128
# set-max-listpack-value 64

cvandeplas commented 1 month ago

I added the message for both cases. Also (tried) to fix the python test raising the variable type. @Rafiot Can you approve test workflows again to see if the python fix is OK now?

cvandeplas commented 1 month ago

Thanks for the pointer, I originally did it using yet another error method, however that resulted in something not visually clean. I finally ran mypy locally and fixed the type issue. I should have tested it manually the first time...