Add possibility to edit a monitored url

Lookyloo / monitoring

Example project to monitor a list of websites and detect changes

BSD 3-Clause "New" or "Revised" License

5 stars 2 forks source link

Add possibility to edit a monitored url #17

Closed FafnerKeyZee closed 11 months ago

FafnerKeyZee commented 1 year ago

Hey,

Should be great to be able to edit a monitored url (add exception, change interval between captures , etc etc)

Br,

Rafiot commented 11 months ago

Knows bugs:

[x] impossible to remove last domain/regex (list empty, ignored)
[x] Python module doesn't supports authentication
[x] Tests are failing: https://github.com/Lookyloo/monitoring/actions/runs/5555911342/jobs/10147708250

Rafiot commented 11 months ago

[x] add update method in Python client

Rafiot commented 11 months ago

It is implemented.

One thing to keep in mind for now: updating the comparison settings will overwrite the existing settings. Foe example, if you want to add a new domain in the ignore list, you must also pass all the existing ones.

The solution will probably be to add a new endpoint where the user can decide what the merging mechanism should be (add/replace/delete).

FafnerKeyZee commented 11 months ago

Hey,

Looks fine for my use. Thanks a lot

BT :)

Rafiot commented 11 months ago

Ok, I'll close this one for now and open new issues for improvments.