Looooong / Unity-SRP-VXGI

Voxel-based Global Illumination using Unity Scriptable Render Pipeline
MIT License
774 stars 63 forks source link

PostProcessingV2 not working on VXGI #18

Closed Wenzy-- closed 5 years ago

Wenzy-- commented 5 years ago

Hi,Looooong,I found PostProessingV2 not working on VXGI. Usually,i follow this steps can make it work.

1.Download postProcessingV2 package,(I have tried 2.1.7 and 2.0.17) 2.Add two scripts: Post Process Layer and Post Process Volume in the main Camera.

  1. Set the camera layer into "Postprocessing" 4.Create a Post-Processing profile in the Assets file and assign it to the Camera's Post Process Volume component's Profile

Then,in the Post Process Volume component ,click the is Global and add different effect on it will see the PostProcess effect.Like Vignette or sth else.

But in VXGI is not successful ,did I miss any steps?

Looooong commented 5 years ago

Well, I didn't implement VXGI to be compatible with Post Processing. The same thing happens to ProBuilder. Because SRP allows us to customize the render pipeline, it is possible to break the compatibility with other tools. And sadly, I don't know how to incorporate VXGI with other tools and library.

Wenzy-- commented 5 years ago

Thanks.I would love to make it compatible if I can.Unfortunately I don't know a lot about shader. I saw SEGI can support postprocessing.(Besides this one,i think VXGI is better than SEGI in many aspects)Is there any easy way I can modify for a test?Like last time u told me about how to add the ambient value.Maybe there's not that easy as I thought.

Looooong commented 5 years ago

SEGI can do that because it doesn't mess with the render pipeline. The library add hooks to render pipeline and apply additional image effect to the final render result (imagine painting on an existing image).

Looooong commented 5 years ago

I'm adding support for post-processing at #20 . You can check that branch out and test if it's working.

Wenzy-- commented 5 years ago

Thanks,Looooong.That works very well!I have tested the Bloom and Vignette.

Looooong commented 5 years ago

Good to know that it works for you. I'm afraid that any effect relying on screen-space depth, normal or motion vector doesn't work, yet.

Wenzy-- commented 5 years ago

I will do more tests later. Do u have twitter account?I want to recommend this addons when I release some experimental project based on VXGI.If there's not I will just post the GitHub link directly

Looooong commented 5 years ago

I do have a Twitter account, but I seldomly use it. You can just refer to the Github Repo directly.

Looooong commented 5 years ago

I have merged this feature onto the master branch. Future development will enable more effects on the post-processing stack.