search

Loop3D / map2loop

MIT License
9 stars 9 forks source link

fix: Remove hjson and rely on json only #109

Closed RoyThomsonMonash closed 2 months ago

RoyThomsonMonash commented 2 months ago

Description

Removing the hjson dependency as the JSON files used are simple enough without Loop having to build and maintain the hjson library in the loop3d channel. Note this is for merging into v3.2 not the current version.

Also note that the current CI/CD tests are failing due to LoopProjectFile having multiple thicknesses but both master and v3.2 branches in map2loop do not have them yet. Should we pin LoopProjectFile to v0.1.3 until multiple thicknesses are merged or just merge in multiple thicknesses soon?

Also there is a separate linting issue in one of the tests causing linting to fail.

Fixes #64

AngRodrigues commented 2 months ago

Think it's good now, thanks @RoyThomsonMonash!
@lachlangrose I'll merge this Wednesday morning; merge should also fix the CI issues in the v3.2 branch. Let me know if any comments until then.

AngRodrigues commented 2 months ago

@lachlangrose thanks for reviewing!