Loop3D / map2loop

MIT License
9 stars 9 forks source link

fix: added check for collocated points #125

Closed rabii-chaarani closed 1 month ago

rabii-chaarani commented 1 month ago

Description

A quick fix to remove and avoid collocated points in interpolation

Fixes #123

Type of change

How Has This Been Tested?

Tested on Jupyter Notebook using the example provided in issue #123 The interpolator doesn't return exceptions and works as expected

Checklist:

Checklist continued (if PR includes changes to documentation)

lachlangrose commented 1 month ago

Looks ok but would it be worthwhile checking so see if the entries are true duplicates or just collocated? If they are collocated do you want to choose one or average? If they are true duplicates dropping one is ok. I would also alert the user to what has been done by logging a warning.