LoopKit / G7SensorKit

G7 CGMManager for Loop
5 stars 14 forks source link

Add Dexcom One+ to allowed prefix #25

Closed marionbarker closed 5 months ago

marionbarker commented 5 months ago

I am not able to test this but this matches code used successfully by the iAPS community.

marionbarker commented 5 months ago

I modified the start up message to be more generic: "This app" instead of "Loop".

Franeczek commented 5 months ago

.

ps2 commented 5 months ago

Did you test this? Is appname being set for G7?

marionbarker commented 5 months ago

I tested modifying appName, but I'm sure I did it the "wrong" way.

Modified LoopKit/LoopKitUI/Extensions/Environment+AppName.swift (line 14) from:

This is the screen with that change to the code and French selected as the language.

hard-coded-defaultValue-g7-french

ps2 commented 5 months ago

App name needs to be injected into the environment, like this: .environment(\.appName, Bundle.main.bundleDisplayName); search, and you'll see an example of that in the onboarding. Eventually we hope that this will just be done once at the Loop level, and not at each plugin, but since plugins vend UIKit views instead of SwiftUI views; we have to do this for now.

marionbarker commented 5 months ago

I modified the PR to just have the one on-topic modification.