Closed marionbarker closed 5 months ago
I modified the start up message to be more generic: "This app" instead of "Loop".
.
Did you test this? Is appname being set for G7?
I tested modifying appName, but I'm sure I did it the "wrong" way.
MAIN_APP_DISPLAY_NAME
in LoopConfigOverride.xcconfig to appNameRename
and that is what is displayed as the display name for the app
Modified LoopKit/LoopKitUI/Extensions/Environment+AppName.swift (line 14) from:
static let defaultValue = "Loop"
to:static let defaultValue = "HardCodedSwift"
This is the screen with that change to the code and French selected as the language.
App name needs to be injected into the environment, like this: .environment(\.appName, Bundle.main.bundleDisplayName)
; search, and you'll see an example of that in the onboarding. Eventually we hope that this will just be done once at the Loop level, and not at each plugin, but since plugins vend UIKit views instead of SwiftUI views; we have to do this for now.
I modified the PR to just have the one on-topic modification.
I am not able to test this but this matches code used successfully by the iAPS community.