LoopKit / Loop

An automated insulin delivery app for iOS, built on LoopKit
https://loopdocs.org
Other
1.51k stars 1.3k forks source link

Carb Entry Screen Absorption Time Selected First Is Changed After Touching Emoji's #1616

Closed Hencowitz closed 2 years ago

Hencowitz commented 2 years ago

Describe the bug There have been multiple times where when we do not choose an emoji for the carb entry screen and just enter in the carbs and then the absorption, and change the absorption to say 5, but then decide to enter in the carbs using an emoji, the chosen absorption for the meal, will then change with the emoji. This is also true for Loop Master. The issue is that sometimes you know what the absorption for a large meal will be, and while making dosing decisions and looking at the food, you change up the order of the food or decide to use emoji's instead of just entering nothing (which we do often) and your 5 hour absorption meal is suddenly put to 30 minutes because you used a lollipop to represent the icing on the cake you are going to eat after the steak and potato.... Export-20220302T025544Z.zip

Attach an Issue Report Tap the Loop settings icon on the bottom of the screen, then tap Issue Report and attach it to this ticket.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'carb entry'
  2. Click on ' enter carbs' skip to enter absorption as if you were not going to enter your food type
  3. Decide that you are going to try and emoji your food type and choose emoji's like lollipop
  4. Watch your 5 hour absorption change to 30 min

Expected behavior Whatever your initial intentions for absorption are, once you go back and change your mind and enter emoji's or change the order of the emoji's, it will override your previously selected and purposely chosen meal absorption. Screenshots If applicable, add screenshots to help explain your problem.

Phone

Loop Version

CGM

Pump

Additional context We had a few scary lows with my daughter before realizing that the absorption times we chose were overwritten, because we changed our mind and entered emoji's. Also, our daughter likes to push the emoji's and if she was doing self care at school, she could put them in the wrong order or do it out of order of input and choose absorption first-since that’s usually our first entry in our house, and accidentally change the absorption before anyone knows. I understand the purpose of emoji's but once that line is skipped or left blank, and you change the absorption, I don't think it should be able to change it.

marionbarker commented 2 years ago

Update for Loop dev.

First graphic shows current behavior (with LoopKit PR 422 applied).

add-carb-issue-01

If user selects a fast emoji, then absorption time changes to fast and remains fast regardless of other emoji selections.

At this point, the only way to change absorption time is to use the picker-wheel.

There has been some discussion on zulipchat of modifying the code to have the medium emoji displayed initially. This is mocked up in the following graphic. This demonstrates a behavior that I think is problematic for this interface, regardless of which section of emojis is displayed initially.

The accidental tap of the emoji has locked the absorption to medium.

add-carb-issue-02

marionbarker commented 2 years ago

Using the first graphic from the prior comment.

If the user first taps on any one of the three icons in the middle of the first graphic and then taps on the food emoji, that default icon absorption time is locked in regardless of how many food emoji are selected.

ps2 commented 2 years ago

@marionbarker The original description of this ticket fits a bug that was fixed: when the user selects an absorption time manually, selecting a custom emoji should not override it. That was fixed. I think separate use errors should be covered in separate tickets.