Custom Presets - Manual input field for Target Range is unconstrained and allows 0mg/dL or 400mg/dL to be set

kellyisworking commented 8 months ago

Describe the bug During Custom Preset configuration, for both Saved and Custom (single use) Presets, the Target Range uses manual input for setting the low and high value. Low value can be entered as low as 0 mg/dL and high value can be raised as high as 400mg (at least).

Given the low value is unconstrained, it is unclear if the dose will still be constrained by Glucose Safety Limit. Note: this should be investigated.

Additionally the UI should introduce picker interactions rather than manual inputs consistent to Correction Range in Therapy Settings to mitigate against use error. See below.

To Reproduce Steps to reproduce the behavior:

Go to 'Custom Presets'
Click on '+' to create a new saved preset or 'Custom' to create a temporary preset
Scroll down to 'Target Range'
Tap into input fields, enter 0 or 400 into lower and upper bound.

Expected behavior The UI should introduce picker interactions rather than manual inputs consistent to Correction Range in Therapy Settings to mitigate against use error.

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

Additionally, two recommendations to increase consistency:

Change Target Range to Correction Range across the Preset interface
Display warning message as user’s selection approaches high and low limits
- Trigger a low range value warning and verify the following copy: “A value you have entered is lower than what is typically recommended for most people.”
- Trigger a high range value warning and verify the following copy: “A value you have entered is higher than what is typically recommended for most people.”
- Trigger a high and low range value warning and verify the following copy “Some of the values you have entered are outside of what is typically recommended for most people.”

Screenshots

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 30 days with no activity.

marionbarker commented 7 months ago

Bump

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 30 days with no activity.

marionbarker commented 6 months ago

Bump

marionbarker commented 1 month ago

I confirmed that the glucose target guardrails are not respected when override values exceed the guardrail. Actually - I don't think this is a problem on the higher end. Next test will be low glucose end. Using a test phone:

set override to be 0 to 800 mg/dL
set CGM to constant value of 510 with noise, Loop autobolus issued a bolus with glucose at 519 mg/dL

marionbarker commented 1 month ago

The glucose safety limit is respected. So I think this is a cosmetic issue for the min target, but should be resolved. The upper limit of the target is used as entered. Not sure if we want to enforce guardrails on that value.

Using a test phone

set override 0 to 800 mg/dL, this is displayed on the glucose graph as target range.
set CGM to constant value of 40 with noise
- Glucose Safety limit set to 80 mg/dL
  - Loop does not autobolus or recommend bolus because glucose is below safety limit, even though glucose is within override target range and glucose forecast is 332 mg/dL
  - Loop issues 0 U/hr TempBasal rate
set CGM to constant value of 70 with noise
- Glucose Safety limit still at to 80 mg/dL
  - Loop does not autobolus or recommend bolus because glucose is below safety limit
  - Loop issues 0 U/hr TempBasal rate
- Glucose Safety limit set to 70 mg/dL
  - Loop restores basal to scheduled value
  - Loop does not recommend bolus or autobolus because forecast is below top of target
Modify override target range to 0 to 400, so that top level (800) is below forecast (457)
- Glucose Safety limit still at 70 mg/dL, Glucose still around 75 mg/dL
- Loop recommends bolus and autoboluses

LoopKit / Loop

Custom Presets - Manual input field for Target Range is unconstrained and allows 0mg/dL or 400mg/dL to be set #2126