LoopKit / Loop

An automated insulin delivery app for iOS, built on LoopKit
https://loopdocs.org
Other
1.45k stars 1.27k forks source link

Modify handling of carbs entered at the same Hour and Minute #2134

Open marionbarker opened 5 months ago

marionbarker commented 5 months ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like Possible solution:

Additional context This issue with the way Nightscout handles carb entries (see https://github.com/nightscout/cgm-remote-monitor/issues/8185) was discovered by someone using remote carb entries, but it also happens when entering carbs in Loop UI itself.

Test Case:

  1. Enter carb values repeatedly in the Loop UI with different values and absorptions times.
    • First add a 10 U non-pump bolus so no bolus is recommended after each carb entry
    • Then add 1, 2, 3, 4 and 5 U entries with 3 hours absorption using the same entry time of 13:00 on the time picker
    • Repeat the 1-5 for 30 min absorption, then 5 hour absorption and then 1 hour absorption times
  2. Twenty entries was enough to hit the 1 in 60 chance two times

The display order of the entries does not match the entry order because of different seconds in the 13:00 saved timestamp.

carb-order-and-ns-issue

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity.

marionbarker commented 3 months ago

Bump

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 30 days with no activity.

marionbarker commented 2 months ago

Bump