Feature request: Make it easier to save Favorite Food from Carb Entry screen

LoopKit / Loop

An automated insulin delivery app for iOS, built on LoopKit

https://loopdocs.org

Other

1.45k stars 1.28k forks source link

Feature request: Make it easier to save Favorite Food from Carb Entry screen #2135

Open marionbarker opened 4 months ago

marionbarker commented 4 months ago

Is your feature request related to a problem? Please describe.

Many people get frustrated when creating Favorite Foods.

If they happen to start from the Settings, Favorite Food screen, it is really straightforward
If they try to create one from the Add Carb Entry screen, they are not sure how to get the "Save as favorite food" button to be active
- In order to make it active, they must tap on the plate and then select at least one emoji

Describe the solution you'd like The selection of a food emoji should not be required on the Carb Menu to activate that button.

I made a code change and this changed the behavior.

See PR #2136

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity.

marionbarker commented 3 months ago

Bump

carolinecreamer commented 3 months ago

@marionbarker Hi!! I am not sure how to direct message on Git, but I am a computer science student at the University of Michigan. I am currently taking a software engineering course and our final project is to contribute to an open source project on Github. I am a type one diabetic and am hoping to work on diabetes technology in the future, so I was hoping to contribute to the Loop Repo, but wanted to make sure this is okay with you first? I am thinking about working on this feature along with #2127.

marionbarker commented 3 months ago

@carolinecreamer

Here are some links for you to review.

Please join zulipchat and join all the streams but especially the development stream.

Use Zulipchat forums for Loop.