search

LoopKit / Loop

An automated insulin delivery app for iOS, built on LoopKit
https://loopdocs.org
Other
1.51k stars 1.3k forks source link

Make Checkmark List Items easier to see #2238

Closed marionbarker closed 1 month ago

marionbarker commented 1 month ago

Is your feature request related to a problem? Please describe. It can be hard to see where to tap to change selections, especially in dark mode on an iOS 18 phone.

Describe the solution you'd like Modify the code to make the open circles easier to see.

Describe alternatives you've considered N/A

Additional context This is a one line change to https://github.com/LoopKit/LoopKit/blob/3ce43ded238a776f7/LoopKitUI/Views/CheckmarkListItem.swift#L77

The graphics below are from left to right:

Dark Mode: Silence Pod

silence_pod_stroke_empty_1_2

Light Mode: Insulin Selection

insulin_type_stroke_empty_1_2

From those screens, I think lineWidth of 1 is best.

Here are a few more screens (in dark mode) with the lineWidth: 1 modification.

various_dark_lineWidth_1

elnjensen commented 1 month ago

Agreed, these are really hard to see in Dark Mode with the current design.

ps2 commented 1 month ago

Yes, I agree it's too faint in dark mode. It might need a line width increase. I'd still like to stick to existing iOS conventions for color, though. See the following screen shots from iOS mail and Display & Brightness screen in iOS Settings.

IMG_2543EA3A14AC-1 IMG_1677

itsmojo commented 1 month ago

Thanks for running this one down & generating a PR for this Marion. From the provided Loop pics I personally prefer using a lineWidth of 2 for these open circles to make things more clear for my aging & color blind eyes, particularly in dark mode.

marionbarker commented 1 month ago

Fixed with https://github.com/LoopKit/LoopKit/pull/549