LoopPerfect / buckaroo-recipes

The official book of recipes for Buckaroo 📒
https://www.buckaroo.pm
MIT License
6 stars 4 forks source link

Diff to add iOS support to boost/thread #114

Closed cpsauer closed 6 years ago

cpsauer commented 6 years ago

boost/thread works great on iOS, but the buckaroo BUCK file's platform_* parameters are missing regexes for iOS support. We added them successfully for our project and wanted to contribute back. It sounded like the way you'd like us to do that was to just submit an issue, but if there's a better way for us to contribute, let us know.

Here's the diff to the boost/thread/BUCK file to make things work on iOS:

diff --git a/Product/buckaroo/official/boost/thread/BUCK b/Product/buckaroo/official/boost/thread/BUCK
index cd035314..57707f0d 100644
--- a/Product/buckaroo/official/boost/thread/BUCK
+++ b/Product/buckaroo/official/boost/thread/BUCK
@@ -15,6 +15,7 @@ cxx_library(
   ]),
   platform_srcs = [
     ('default', glob(['src/pthread/**/*.cpp'])),
+    ('^iphoneos.*', glob(['src/pthread/**/*.cpp'])),
     ('^macos.*', glob(['src/pthread/**/*.cpp'])),
     ('^linux.*', glob(['src/pthread/**/*.cpp'])),
     ('^windows.*', glob(['src/win32/**/*.cpp'])),
@@ -27,6 +28,7 @@ cxx_library(
   ],
   platform_compiler_flags = [
     ('default', posix_flags),
+    ('^iphoneos.*', posix_flags),
     ('^macos.*', posix_flags),
     ('^linux.*', posix_flags),
   ],

@njlr It looks like the actual BUCK file lives in one of your repos?

njlr commented 6 years ago

Hi @cpsauer thanks for the contribution! Yes we have our own repo for the BUCK files.

I have created a PR with your change here: https://github.com/LoopPerfect/buckaroo-recipes/pull/115