search

LoopPerfect / buckaroo-recipes

The official book of recipes for Buckaroo 📒
https://www.buckaroo.pm
MIT License
6 stars 4 forks source link

google/brotli BUCK meant for newer version #120

Closed cpsauer closed 5 years ago

cpsauer commented 5 years ago

Friendly heads that the BUCK file for brotli seems to be for a more current version of brotli than the 0.5.2 listed in the json. It references the include folder, which only looks to exist in current versions. Just grabbing the contents of the c directory in the current version of brotli worked for me.

Quick links: Brotli recipe json: https://github.com/LoopPerfect/buckaroo-recipes/blob/master/recipes/google/brotli.json Referenced version of brotli: https://github.com/google/brotli/tree/v0.5.2 Current brotli with the include folder used in the BUCK file : https://github.com/google/brotli/tree/master/c

njlr commented 5 years ago

Thanks for letting us know 👍

Does v0.5.2 work for your purposes? We can port a later version if required.

cpsauer commented 5 years ago

I think easiest and best would be to update the buckaroo recipe's json to reference the "c" directory of the current version of brotli (1.0.7).

That seemed to fix things for me locally with the current BUCK file. (As is, the current BUCK file doesn't expose the right headers, so it's problematic trying to build on top.).

I'd do that and submit a pull request, but I'm not sure exactly what format is expected in the json. @njlr , would you be down to point the recipe to the new version of brotli's source?

njlr commented 5 years ago

@cpsauer Sure! The cookbook procedure is a little awkward at the moment (we are actively looking at improving this) so I'm happy to do that part of the process.

Do you have a BUCK file that works for 1.0.7? I can add a new version with the new file pointing to the new sources.

cpsauer commented 5 years ago

Your current BUCK file (referenced in the json) works great for 1.0.7!

[Just not for the v0.5.2 it's ostensibly meant for.]

So only change is that the json needs to point into the //c/ directory of brotli 1.0.7. Then everything should work!

njlr commented 5 years ago

I have added 1.0.7: 

buckaroo update
buckaroo install google/brotli

The Buck port is here: https://github.com/buckaroo-pm/google-brotli/tree/buck/1.0.7

cpsauer commented 5 years ago

Double checked that this works on my machine! Appreciate your fixing this. I've moved back off my patched version to the recipe. Thanks, @njlr! I also like that you also chanced the BUCK to work with the whole repo, rather than a subdir.

cpsauer commented 5 years ago

(down to close if you are)