search

LoopPerfect / buckaroo-wishlist

Meta repo for Buckaroo package requests ✨
https://buckaroo.pm
MIT License
9 stars 0 forks source link

zdevito/ATen #116

Open kindlychung opened 5 years ago

njlr commented 5 years ago

https://github.com/zdevito/ATen

njlr commented 5 years ago

Looks like it depends on https://github.com/pytorch/pytorch

kindlychung commented 5 years ago

Really? I thought pytorch depends on aten.

njlr commented 5 years ago

So there's this line https://github.com/zdevito/ATen/blob/e5dd10dad89d870e922daf7cb1ceda1b8c30e9ca/aten/src/ATen/DeviceGuard.h#L4

#include <c10/Device.h>

which I think comes from here? https://github.com/pytorch/pytorch/blob/master/c10/Device.h

nikhedonia commented 5 years ago

maybe the way we should interpret this is: c10 is an independent library that happens to reside in the pyTorch repository.

A closer look at the CMakeLists.txt might be valuable: https://github.com/pytorch/pytorch/blob/master/c10/CMakeLists.txt

njlr commented 5 years ago

There is also an "aten" inside the pytorch repo:

https://github.com/pytorch/pytorch/tree/master/aten

Do you know if these are different?

njlr commented 5 years ago

The aten in Pytorch does not build on its own https://github.com/pytorch/pytorch/issues/12452

njlr commented 5 years ago

I have added c10 from Pytorch https://github.com/LoopPerfect/buckaroo-recipes/commit/66df7e3e28296dd891e01c5aa85574cac86835df