Replace "listener" method by "enter" and "leave"

[hems]

A few points regarding the updated implementation:

• When fetching the users in the room, through L.rooms.people we will get a list of users and every user has a socket_id property.
• When a user leave the room by closing the browser, we only have his socket_id information, so for removing the user we should just listen to the listener:removed
• If we want to show the message "user left the room", we will have to use his socket_id to find his information cached on the client side, like #{username} for instance. @thomas1602 / @stefanoortisi do you think is a good idea to show a message like "#{username} left the room" ? or shall we just remove his icon from the "PEOPLE IN THE ROOM" section?
• We don't need to call the chat/leave method anymore, or use the chat.listener method to notify the user left because the type: 'listener:removed' message will be sent automatically when a user unsubscribe from a room or when a user socket connection is closed ( for instance when the user closes the browser )

So basically, from the HTTP API we will only need to call chat/enter because chat/leave ( and the message type: 'listener:removed' will now be handled server-side by watching the socket connection.

There is more information about leaving on the ticket #338 !

After doing this, i believe we can delete the API method chat/listener, because it was being used just to propaged the listener:added and `listener:removed, and now we will replaced both operations, does that make sense or did i understand something wrong?

[stefanoortisi]

This should be closed now cause we are not dealing with listener:removed event anymore

[hems]

@stefanoortisi we actually dealing with listener:removed !

if the user closes the browser or leave the room this event will go and we have to remove his avatar from the "PEOPLE IN THE ROOM" list

[hems]

@stefanoortisi close this issue if people are leaving the room just by closing the browser, because if you leave by internet connection drop or closing browser or tab it also should receive the listener:removed event!

[stefanoortisi]

alright :+1:

[stefanoortisi]

Ok now the listener:removed event is starting to work. But i have still a small issue: if a guest is already into the chat, i get him on the list when i enter the chat. But if a guest enters while I'm on the room, i don't get any listener:added event.

I double checked if i was actually calling the chat/enter api for logged and unlogged user and i am doing it right.

@hems could you have a look at this particular case?

[hems]

@stefanoortisi i don't know why, but i had a "null" on the room_id for guests!

now it's fixed!

[hems]

this seems to be working very well!

with guests and users! pretty cool