Loopcast / beta

1 stars 0 forks source link

Update "people in the room" logic #335

Closed hems closed 9 years ago

hems commented 9 years ago

@stefanoortisi i implemented people in the room, by calling L.chat.people method on the API just after the room is created

The way it works, is the API method returns

I did already the logic that returns who is the user and who is a guest.

The only problem is that sometimes the "subscription" to the channel, and the "get people in the room" happen at the same time, so it's good to check if the user on the socket.id is itself, like a did on Line 184 but still need some work on the guest avatar and user information

hems commented 9 years ago

@stefanoortisi i can see sometimes there is an error and no people appear in the room, and sometimes the user itself doesn't appear on the room.. i'm trying to figure this out

hems commented 9 years ago

@stefanoortisi the "Follow" button should disappear for the guest as well

stefanoortisi commented 9 years ago

@hems I might probably already fixed this. Can you please check it so we can close it

hems commented 9 years ago

i think it has been working ok!

we just need to tweak the guest "enter" event and do some more testing, but it seems fine