Closed thomas1602 closed 9 years ago
Hi @thomas1602 I thought the profile page is not completely approved yet, so I shouldn't focus too much on its details for now. I followed the design but not as perfect as I can. Let me know when the design of this page is final (or if it's already final) and I'll fix all these small things
oh last thing... HAPPY BIRTHDAY :birthday:
Thanks man :) I never talked to Hanzo about doing the profile page - he is only focusing on the room page (dashboard). So this will be the final page for beta
oh perfect then!
Cool :+1:
I was also thinking about this section of the profile page:
Once you enter edit mode you should be able to change your name, add your occupation and professional genres. Perhaps we could have a chat about this?
Also when I logged in with facebook it used the first part of my email as a username. Lol the email I use for facebook is like super old from when I was a kid. Wouldn't it be better if it adds my facebook username?
yeah, this is something @hems should have a look
@stefanoortisi here is also a link to the play button: http://invis.io/a/SNTQ9AUXQF9Y
@thomas1602 / @stefanoortisi facebook has removed the username from the most recent Graph API.
https://developers.facebook.com/docs/apps/upgrading#upgrading_v2_0_graph_api
One option would be to generate a weird number, as soundcloud does, and use that, so forcing the user to create their own id at the same time, not exposing any user information.
What you think?
peace
Yeah that could work.
@thomas1602 when you edit your occupation, you can insert whatever you want or the user should choose from a pre populated list of occupations available? When we edit the username, occupations and tags, we might have the text editable with the same style, we might need some call to action to make it clear. Maybe we need a design for it
The user will choose from a list of occupations;
DJ/Producer Record Label Agency Promoter Club Festival Listener
I might be adding more later, depending on the kind of users we attract etc. For example it might not only be limited to music in the future.
Yeah ok, could you add the following placeholders for now? We don't need anything for username as @hems said we will generate a random username (user1245)
Maybe we could just put a pencil icon next to the boxes which only appear when you hover around that area?
Look at Linkedin's profile page as an example
@stefanoortisi i just pushed a simple route on the API, called
/api/v1/occupations/all
Which is supposed to list all the occupations so the frontend can get it.
I believe we will have the same for "Genres" and other fields that needs auto-complete on the frontend.
Cool! I was thinking about something like this for the editable text on the cover:
http://vitalets.github.io/x-editable/demo-bs3.html
There is also the select populated asynchronously. What you think?
Interesting. Would be good to see that in the context of the website, and have it styled to fit ( :
Anyway i trust you, if you think it's the way to go for frontend, let's go ( :
yeah I would need a design for it, of course :smile: Anyway, i can also simply write everything from scratch, maybe I'll take even less time
I've pushed an example of the interaction we might have on profile page (username and occupation on the cover). Let me know what you think. Of course we need a better design for the icons and for the alignment of the inputs.
Yeah nice, the style is cool and simple. Its similar to how its done on Linkedin. I will try and fix the design tomorrow
worth saying the play button appears only on rollover ?
@stefanoortisi I think we should try this.
done!
Hi @stefanoortisi
I just got a chance to check out the profile page as I've been away over the weekend, anyway it looks great. I know this is a really small detail but could you add 2px border-bottom to the sets:
Maybe we could do the same to the box which holds the user info (Bio etc). This also applies to all the explore cards on the explore page btw.
Moreover I realised you have left out the icons. I could not find a good version of the location and listener icon. It seems the previous developer had just used screenshots :-1: . There was a designer who gave us these icons but he never sent the png files directly to me, just to the previous developer. I can send him an email
anyway the other icons you can find here: https://projects.invisionapp.com/d/main#/projects/1915497/assets