Confirm username after logging in with Facebook or Google

[thomas1602]

Users will no longer have random numbers appended to their urls

[thomas1602]

@stefanoortisi @hems

[thomas1602]

[thomas1602]

I think it would be better to start with this layout. Basically this will appear in the same window after the user either signs in with Facebook or Google! We can this discuss this in more detail when you start :+1:

[hems]

@JohnnyRuvac i will created the template /templates/login/confirm_username.jade, soon i'll change the login logic to redirect to that page in case it's the first time the user logs in.

You can see how the /templates/login/successful.jade already works, for now it only receives the user data from the backend and forward to the opener page.

@JohnnyRuvac have a look on the sucessful.jade template, maybe we could just use that one and don't need to create a new one, since successful.jade already have the flag "is_first_time", so in that case we could just show this layout.

I'm not sure if we should add all the css and javascript from the website on that page since it's very small and simple, so maybe we could do that one totally "standalone" with the css inline on the page just for the sake of not loading all the styles for such a small page?

Anyway, we speak about this when you actually start doing it! I'm just thinking loud here!.

peace

[hems]

@JohnnyRuvac although including the whole javascript will give you instant access to the api.loopcast.user.is_available method which you will need to check in order to say if the username is available or not !

[hems]

still i need to do the backend method to let the user update the username.

[hems]

i just added user.edit_username and user.is_available methods to the frontend API

[thomas1602]

@JohnnyRuvac seems to be working fine, just a couple of things on the design

Only the username should be bold, and "Thanks" should not be bold.

Could you also remove the margin between the two input fields? I think it would look better if they stick together :+1:

[ondrejrohon]

Done. @hems can you please check if your backend code really changes the name? I have this suspicion that it doesn't. After confirming new name, logging out and logging back in, I still see my name unchanged.

[ondrejrohon]

Idea for improvement:

after successfully changing name, we should maybe show some confirmation to the user that it was changed. And after some delay close the pop up. What do you think guys?

[hems]

@JohnnyRuvac i agree with you ! but for now i believe we will be just closing the window and pointing the opener window to the profile page !

I'll double check the backend code for updating the username now!

[hems]

@JohnnyRuvac would be nice to add the issue number to the commit's comments ( when possible, many times i forget as well ) so then i can see where the code related to the issue is!

[hems]

so i checked the console and there was an error coming regarding an issue on the backend.

i just stopped calling "window.close", opened the Developer Tools and went to the network tab!

[hems]

it all works now, we just need to do a couple of visual fixes in order to match the design and i think we will be done (( :

[hems]

it seems to be perfect now.