Loopcast / beta

1 stars 0 forks source link

Facebook login dialog is too big for our login window #619

Closed thomas1602 closed 8 years ago

thomas1602 commented 8 years ago

@stefanoortisi I know you've tried to increase the size of the login window to fix this but its still not good. I don't think the solution is to increase the size of the window - there must be a way for facebook's dialog to resize to our window?

screen shot 2015-11-17 at 16 10 20

The message below tells us that its possible to solve this user experience issue by using the javascript SDK. Can you look into this please?

screen shot 2015-11-17 at 16 09 06

hems commented 8 years ago

@stefanoortisi i actually found out there was an option "display=popup" on the backend SDK that changed it all! what a joke! why they don't do this automatically! now it works!

although it seems that the pop up doesn't open in the center of the page..

please have a go and see if it all works for you and if opens in the center and then close the issue?

stefanoortisi commented 8 years ago

@hems the popup is centered for me. I think it was kind of remembering some old position for you? Maybe we can close this one

thomas1602 commented 8 years ago

@stefanoortisi yeah think we can close it, was just wondering if you could show me where to resize the window? Might need to make a it slightly taller and wider

stefanoortisi commented 8 years ago

search for the login_popup.coffee! you gonna find the size numbers there

thomas1602 commented 8 years ago

thank you

hems commented 8 years ago

closed!