Loopcast / beta

1 stars 0 forks source link

player doesn't stop for guest when "_on_live_stop" happens #681

Closed hems closed 8 years ago

hems commented 8 years ago

I have been testing streaming from 2 computers, one as guest and another as host and sometimes when i press GO OFFLNE on the host, the "OFF AIR" appears to the guest, but the player still with a PAUSE button and the time running !?

screen shot 2015-12-09 at 22 05 57

Also "You are listening now live" and "the user has ended the stream" is showing up twice most of the times.. i'm not sure if it's something related here?

hems commented 8 years ago

i can see on_live_stop being called twice from the terminal!

stefanoortisi commented 8 years ago

I can see the player stops in my case. And it should actually stops, because whenever I get a "status changed" event from the socket with the live:false, the player will stop. Might be something related to the socket events? I'm saying this because I noticed that the other problem you talked about (the twice showing up of live notifications) is due to a double event triggered by the socket, every time the room status changes. You can see it from the console: if you filter the logs by this keyword "[Room DEBUG]", you will see all the events triggered by the socket. The only thing i've improved is showing/hiding the live label on the player when the room goes offline/online.

Can you please double check this double triggering thing on the socket?

hems commented 8 years ago

@stefanoortisi i just fixed the double socket message for stream_end

hems commented 8 years ago

i fixed the double socket for stream_end..

will double check everything again now and see what is happening and let you know