Loopcast / beta

1 stars 0 forks source link

Not possible to click follow #708

Closed thomas1602 closed 8 years ago

thomas1602 commented 8 years ago

@stefanoortisi it's not possible to click follow on users from the explore page any longer, also on users profile pages

hems commented 8 years ago

it works for me on chrome, osx on beta.loopcast.fm

hems commented 8 years ago

what doesn't work for me, is for instance if i go to my profile, then a room, then to explore page then i click "people" then when i click "Follow" the button doesn't change to "Unfollow", but the follow actually happens if you refresh the page.

same for profile, if i go deeplinked it works, but if i navigate from one page to the other the button stops changing when i click

thomas1602 commented 8 years ago

I can now click follow and the button changes but there is a big delay. Doesn't work as smoothly as before - are you waiting to change the button until it follows on the backend now?

thomas1602 commented 8 years ago

It seems that the transition is effected by the internet speed?

stefanoortisi commented 8 years ago

yes @thomas1602 , it's exactly how it was working before: the button is changing its state after the backend response. Anyway, I can either disable the button in a loading state while waiting for the backend response, or set it with the final state before the backend response.

Which way do you prefer?

hems commented 8 years ago

@stefanoortisi i think it should instantly change for the user and then if for some reason an error happen it has to change back.

ideally if you get a "404" on the API ( it means the server is restarting ) you can automatically retry one of two times ( but not infinitely otherwise it will be retrying forever if some bad error happen ).

peace !

hems commented 8 years ago

@stefanoortisi / @thomas1602 or we could get someone at "fiver" to do us a loading logo using the loopcast loop, or we just make a generic a gif from http://www.ajaxload.info :P

thomas1602 commented 8 years ago

I agree it should follow instantly and if the backend responds with an error we change it back and trigger an error message using notify js "Could not follow user, please try again later"

hems commented 8 years ago

@thomas1602 perfect