search

Loopring / protocols

A zkRollup DEX & Payment Protocol
https://loopring.org
327 stars 120 forks source link

[counterfactual_nft] Disable minting on L1 and add creator #2629

Closed kongliangzhong closed 2 years ago

kongliangzhong commented 2 years ago

Changes:

  1. disable minting on L1
  2. add creator info for token id (in order to keep compatible with opensea)
Brechtpd commented 2 years ago

Looks good to me. But maybe best if we move this to a different contract instead of modifying the current general purpose CounterfactualNFT contract? The new logic is kind of special and isn't really a general NFT contract anymore so a new separate contract living next to the current one makes sense to me.

kongliangzhong commented 2 years ago

Looks good to me. But maybe best if we move this to a different contract instead of modifying the current general purpose CounterfactualNFT contract? The new logic is kind of special and isn't really a general NFT contract anymore so a new separate contract living next to the current one makes sense to me.

You mean a contract that extends CounterfactualNFT contract?

Brechtpd commented 2 years ago

Yeah I think that should work.