search

Loopring / protocols

A zkRollup DEX & Payment Protocol
https://loopring.org
334 stars 123 forks source link

[protocol] update DestroyableWalletAgent.sol #2652

Closed kongliangzhong closed 2 years ago

Brechtpd commented 2 years ago

Any reason for this change? A DestroyableWallet shouldn't really have a deployed wallet at any time because then it would keep being able to authorize transactions on its own even if the wallet is marked as destroyed (bypassing the correct checks here).

kongliangzhong commented 2 years ago

DestroyableWalletAgent was used as LoopringWalletAgent. I think this is wrong, we should use LoopringWalletAgent directly. You are right, no need to make this change.