search

Loopring / protocols

A zkRollup DEX & Payment Protocol
https://loopring.org
327 stars 120 forks source link

[protocol] update DestroyableWalletAgent.sol #2652

Closed kongliangzhong closed 1 year ago

Brechtpd commented 1 year ago

Any reason for this change? A DestroyableWallet shouldn't really have a deployed wallet at any time because then it would keep being able to authorize transactions on its own even if the wallet is marked as destroyed (bypassing the correct checks here).

kongliangzhong commented 1 year ago

DestroyableWalletAgent was used as LoopringWalletAgent. I think this is wrong, we should use LoopringWalletAgent directly. You are right, no need to make this change.