LoosC / systemsseRology

Machine learning tools for the analysis of systems serology data
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Meaning of ellipses on PLS-DA scores plot #14

Closed malisas closed 3 years ago

malisas commented 3 years ago

Hi, thanks for making the systemsseRology package available!

I noticed a comment in the code for systemsseRology::visualize_ropls_scores() which very briefly says

# confidence levels for ellipses

The ellipse drawing function that is called is ggplot2::stat_ellipse() (documentation here).

I think the comment could be a little misleading because the ellipses being drawn are data ellipses, not confidence ellipses, so you may want to change the text to something like:

# The level at which to draw the ellipse for the data ellipse

I had a brief exchange with your colleague, Deniz Cizmeci, to make sure this detail is correct. Thanks for your attention to this minor point. For one of our recent studies, this was a question that came up during manuscript preparation, so I wanted to bring it to your attention.