search

LooseLab / readfish

CLI tool for flexible and fast adaptive sampling on ONT sequencers
https://looselab.github.io/readfish/
GNU General Public License v3.0
169 stars 33 forks source link

Names are confusing in the stats module #298

Open Adoni5 opened 12 months ago

Adoni5 commented 12 months ago

An idea but it would be nice to rename some of the counters and variables!

We have a lot of intermixing between actions and decisions going on.

Example:

    # Increment total actions count, Unblock, stop_receiving etc.
    self.actions[decision_name] += 1
    # increment count for this decision - single_off, single_on etc.
    self.decisions[kwargs.get("mode")] += 1

It would make more sense (IMO) to be updating self.decisions with decision_name and not mode.

Would be nice to work through these and standardise the names used in Counters