LooseLab / readfish

CLI tool for flexible and fast adaptive sampling on ONT sequencers
https://looselab.github.io/readfish/
GNU General Public License v3.0
164 stars 31 forks source link

Issue289/fix-region-requirement and add Changelog #299

Closed Adoni5 closed 9 months ago

Adoni5 commented 9 months ago

Adds a Changelog to the Readme

Uses @alexomics fix to the Region name being required when tracking the read during stats.

Also addresses a logic issue in the ReadfishStatistics class about tracking overridden actions. Now tracks overridden actions correctly, for both Regions and Barcodes in the Counters.

Adds a big old set of doctests for the _update_condition_counter function.

Finally, I removed the .dev tag from the release, as this is not a dev/test feature release, just a bug fix.

When this is merged, we should tag as 2023.1.1, and yank the 2023.1.0 from PyPI.

Tested (Briefly!) with Barcoded, Barcoded with regions, and just region tomls.