search

LooseLab / readfish

CLI tool for flexible and fast adaptive sampling on ONT sequencers
https://looselab.github.io/readfish/
GNU General Public License v3.0
163 stars 31 forks source link

Argument should be in base args? #308

Closed mattloose closed 7 months ago

mattloose commented 8 months ago

https://github.com/LooseLab/readfish/blob/beb3dffcf96d287e615903032238d231c8498c7f/src/readfish/entry_points/targets.py#L109-L114

Given this is controlling a log file that is specified elsewhere I think this should be alongside base args?

mattloose commented 8 months ago

In addition, are the words "Default enabled." superfluous?

Adoni5 commented 8 months ago

I agree with default enabled being superfluous - but I don't follow about this controlling a log "specified elsewhere"? Can you expand a bit?

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Adoni5 commented 7 months ago

@mattloose any updates

mattloose commented 7 months ago

good question. I don't remember.

Adoni5 commented 7 months ago

Unmemorable