search

LooseLab / readfish

CLI tool for flexible and fast adaptive sampling on ONT sequencers
https://looselab.github.io/readfish/
GNU General Public License v3.0
169 stars 33 forks source link

Feature/pass reads #361

Closed Adoni5 closed 1 month ago

Adoni5 commented 3 months ago
  1. Uses the pass_reads function on the caller, rather than individual calls to pass_read, should be faster and has removed sleeping.
  2. Tidies up the example reads in the explainer about sub_tag and makes them comments.
  3. Added a log statement about generating the aligner description, as it felt to me that after logging "starting main loop" it was hanging, when in actuality a large reference takes a while to generate a description for.

N.B Committed as @satriobio from the remote Vs code server, is this identity theft?

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Adoni5 commented 1 month ago

Fixes #372 in 9ee6b8bf493b1f404abdd28ea6b82f6bee5e3ef9, caused by extra clipping shenanigans of the base-called Results read-id. Was losing the first 3 UUID chars, so no read existed to unblock.