LooseLab / readfish

CLI tool for flexible and fast adaptive sampling on ONT sequencers
https://looselab.github.io/readfish/
GNU General Public License v3.0
169 stars 33 forks source link

DRAFT Feature/minknow6 compatibility #369

Closed Adoni5 closed 1 month ago

Adoni5 commented 2 months ago

Highlights

Adds in compatibility for MinKNOW 6.

[!WARNING] Breaking for any version of MinKNOW <= 6.0.0

It will not run against MinKNOW <= 6.0.0, instead logging a critical message, suggesting a downgrade and raising SystemExit.

Key Changes

Todo before merging

I suggest that we take this opportunity to drop Guppy support entirely.

[!NOTE] We are still using read_number in some trackers, these will definitely stop working properly until they are updated to use read_id

mattloose commented 2 months ago

Do we need to add dorado tests as well?

mattloose commented 2 months ago

I've had a stab at addressing some of these issues in #feature/deprecate-guppy