search

Lootjs / Nuxt-assistant

Apache License 2.0
1 stars 0 forks source link

[Feature Request] Make the THRESHOLD configurable #1

Closed lucasfcnunes closed 1 month ago

lucasfcnunes commented 1 month ago

Description

Fixed 15 items can be too little to test. Make it configurable.

https://github.com/Lootjs/Nuxt-assistant/blob/4c11af7e2e9b55543d32362013054ed88e624896/nuxt-assistant-panel.js#L365

https://github.com/Lootjs/Nuxt-assistant/blob/4c11af7e2e9b55543d32362013054ed88e624896/nuxt-assistant-panel.js#L381

Lootjs commented 1 month ago

Hi! Thanks for reaching out! Do you think this implementation fits your request?

image

image

and by default, threshold now is 20

lucasfcnunes commented 1 month ago

Hi! Thanks for reaching out! Do you think this implementation fits your request?

Yes! Thanks for your rapid response!

Lootjs commented 1 month ago

Thank you for this idea! i'll publish the new version within 2-3 hours

Lootjs commented 1 month ago

Added in 1.20

lucasfcnunes commented 1 month ago

@Lootjs, seems that the code here wasn't updated with this feature. Is this right?

Lootjs commented 1 month ago

@lucasfcnunes not yet. why?

lucasfcnunes commented 1 month ago

@lucasfcnunes not yet. why?

@Lootjs, you just reopened this issue so it's all good. :)

Lootjs commented 1 month ago

@lucasfcnunes here you go https://github.com/Lootjs/Nuxt-assistant/commit/ba16054a88f00d829f46c363b757226f6ad9be34 :))

lucasfcnunes commented 1 month ago

@lucasfcnunes here you go ba16054 :))

Thanks!