search

LootrMinecraft / Lootr

friendly loot
MIT License
49 stars 39 forks source link

Lootr using significant memory allocation #469

Closed ChiefArug closed 5 days ago

ChiefArug commented 1 month ago

https://spark.lucko.me/JVPgvcVKdu?hl=22216,22320 image Seems to be the string concatting here: https://github.com/LootrMinecraft/Lootr/blob/l10n_1.21/src/main/java/noobanidus/mods/lootr/api/data/ILootrInfo.java#L43 which is kinda weird as i dont expect concatting to normally take that much memory :shrug:

Side note, can the default branch be changed to something more recent than 1.16?

noobanidus commented 1 month ago

That's bizarre! I'll make a note to cache that value.

noobanidus commented 5 days ago

I believe this has been resolved in recent versions. Please re-open this issue, or open a new issue, if you experience it further.